forked from dxatscale/sfpowerscripts
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install operation fails when repository has URL encoded space #137
Labels
Comments
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 8, 2024
…rseable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 8, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
5 tasks
The PR improves the error message. I'm working on a PR to fix this upstream. |
I've submitted a bug report upstream (IonicaBizau/git-up#36) and provided a PR. |
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 14, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 14, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 14, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 14, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 14, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 14, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 14, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 15, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 15, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 15, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 15, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 15, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
richard-giraud
added a commit
to richard-giraud/sfp
that referenced
this issue
Nov 15, 2024
…seable This adds a skipped test that should be enabled after flxbl-io#137
The upstream bugs have been addressed and PR #138 will resolve this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
sfp install
fails with the messageError: URL parsing failed.
when the repository URL has URL-encoded spaces. E.g.:[email protected]:v3/project%20name/project%20name
. The%20
seems to give the issues.The remote URL that triggered the issue comes from the Azure DevOps UI. It's something that most any user of ADO will encounter if the repository has a space in its name.
To Reproduce
(Please pardon the imprecision here. The error occurs on a system owned be the client and it's not possible for me to use it to report the issue directly.)
Steps to reproduce the behavior:
origin
remote that lacks spaces.sfp
to build and install the artifacts:sfp build --v DevHub
sfp install -o DevHub
.sfpowerscripts
andartifacts
folders to clean up the existing packages. This needs to be done because the repository URL is included in the resulting artifacts.git remote remove origin
git remote add origin [email protected]:RGENT/Salesforce%20POC.git
sfp
to build and install the artifacts:sfp build -v DevHub
sfp install -o DevHub
Error: URL parsing failed.
Expected behavior
I expect 2 things:
%20
is acceptable. This is how it comes from Azure DevOps.Screenshots
Platform Details (please complete the following information):
sfp
39.2.3 wsl-x64 node-v20.15.1sf
2.65.8 wsl-x64 node-v20.15.1Additional context
This appears to be due to a bug in a dependency:
@flxbl-io/sfp
depends ongit-url-parse
via thegitUrlParse
function call atsfp/src/core/package/SfpPackageInquirer.ts
Line 90 in 299859b
git-url-parse
depends ongit-up
.git-up
depends onparse-url
v8 (^8.1.0
).git-up
needs to be updated to use the latest version ofparse-url
.The text was updated successfully, but these errors were encountered: