Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ClientException: Invalid content-length header [-1] when reading version.json on a Firefox extension #3078

Closed
wants to merge 1 commit into from

Conversation

Chralu
Copy link

@Chralu Chralu commented Jul 8, 2024

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

e.g.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@Chralu Chralu changed the title Bug, fix Bad state : Origin is only applicable to schemes http fix: ClientException: Invalid content-length header [-1] when reading version.json on a Firefox extension Jul 9, 2024
@miquelbeltran
Copy link
Member

Hi @Chralu do you plan to do any changes here or can the PR be merged?

@Chralu
Copy link
Author

Chralu commented Jul 11, 2024

Hi @miquelbeltran ,

my PR partially resolves the issue. We still encounter the ClientException, which is problematic.
Because of this, I would not recommand to merge it.

To completely resolve the issue, I see two options :

  1. Fix upstream http lib.
  2. Use Dio instead of http.

Introducing a new dependency is a big deal, so I wonder what the core team thinks about it.

@miquelbeltran
Copy link
Member

Or maybe this is a bug in Mozilla.

In either case, then let's close this PR, and when a proper solution is available create a new one.

@miquelbeltran
Copy link
Member

As mentioned, I will close this PR for the time being until a complete solution to the mozilla extensions is found. We continue the discussion here: #3028

@Chralu Chralu deleted the Chralu/issue3028 branch October 14, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants