Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_maps_flutter_web] Migrate to google_maps: 8.0.0 #7077

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

@Rexios80
Copy link
Contributor Author

Rexios80 commented Jul 8, 2024

Why are the integration tests skipped? Is it because other steps are failing?

@Rexios80 Rexios80 changed the title [google_maps_flutter_web] package:web migration [google_maps_flutter_web] Migrate to google_maps: 8.0.0 Jul 8, 2024
@stuartmorgan
Copy link
Contributor

Why are the integration tests skipped? Is it because other steps are failing?

Because they are currently disabled

@ditman FYI in case you aren't aware; maybe something you could look at while gardening? @bparrishMines That's assigned to you, are you actively working on it? We shouldn't leave whole tests suites disabled for extended periods if we can avoid it.

@bparrishMines
Copy link
Contributor

@stuartmorgan Yea im going to take a look into it now. I'll try to narrow down the specific test to skip, so we no longer skip all the integration tests.

@Rexios80
Copy link
Contributor Author

@stuartmorgan is there an issue to track running integration tests compiled to WASM in CI?

@@ -32,6 +32,12 @@ dev_dependencies:
flutter_test:
sdk: flutter

dependency_overrides:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll want to drop this override, I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely

@kevmoo
Copy link
Contributor

kevmoo commented Jul 10, 2024

We also likely DON'T want to publish this package depending on a pre-release package.

@Rexios80
Copy link
Contributor Author

We also likely DON'T want to publish this package depending on a pre-release package.

Also definitely the case

@stuartmorgan
Copy link
Contributor

@stuartmorgan is there an issue to track running integration tests compiled to WASM in CI?

@ditman would probably be the best person to answer this; I'm not sure what the current plans are around wasm support and testing for plugins.

@Rexios80
Copy link
Contributor Author

I created flutter/flutter#151664 to track running web integration tests compiled to WASM

@kevmoo
Copy link
Contributor

kevmoo commented Jul 22, 2024

@Rexios80 – can we help you here?

@Rexios80
Copy link
Contributor Author

@kevmoo
The biggest blocker for me personally is flutter/flutter#151426 because without that I can't even run the integration tests compiled to WASM locally. It would be cool if we could get CI running WASM integration tests before we land this but that might not be feasible. I think we will have enough fixing up to do when we try running all package integration tests compiled to WASM so I don't want to add to it if I can avoid it.

I have a deployed WASM site with these changes here: https://beta.madadmaps.com. The performance upgrade from Skia is unreal! I think @ditman is busy with other things right now so that's probably what's actually blocking this from landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants