[Inspector V2] Change selected node heuristic after navigation event triggering a tree refresh #8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
approved these changes
Dec 18, 2024
| @@ -462,6 +462,7 @@ class InspectorController extends DisposableController | |||
| } | |||
| if ((_receivedFlutterNavigationEvent || _receivedIsolateReloadEvent) && | |||
| extensionEventKind == 'Flutter.Frame') { | |||
| _refreshingAfterNavigationEvent = _receivedFlutterNavigationEvent; | |||
There was a problem hiding this comment.
could there be a race where this is set again (after receiving another event here) before we reach the if statement you added below?
There was a problem hiding this comment.
Yes, it could. I don't think it's likely and the consequence would just be we would then walk down the tree to find the closest matching, so it's not the worst outcome. However, I've added a TODO (below). I initially was passing the value for "refreshingAfterNavigationEvent" down the call chain, but realized that would involve changing the interface to onForceRefresh for the InspectorServiceClient which I didn't want to do:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1423
Currently, when live reloading of the widget tree is enabled, the widget tree is reloaded when:
For both, we try to determine the node to select in the reloaded tree by walking up from the selected node to its nearest unchanged ancestor, then walking down to find a node matching its name. This makes sense for hot-reloads, but for navigation events entire branches of the tree have changed.
This PR changes the heuristic after navigation events to simply select the closest unchanged ancestor.