Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-refresh the widget tree on navigation events #8622

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Auto-refresh the widget tree on navigation events #8622

merged 1 commit into from
Dec 12, 2024

Conversation

elliette
Copy link
Member

@elliette elliette commented Dec 11, 2024 •
edited
Loading

Work towards #1423

We already added support to auto-refresh the widget tree after a hot-reload. This PR also auto-refreshes the tree after any Flutter navigation events.

Hopefully with this change users will never have to manually refresh the widget tree!

Note: After this PR lands I'm going to follow up with a PR to turn on auto-refreshing on by default.

@elliette elliette requested a review from a team as a code owner December 11, 2024 00:52
@elliette elliette requested review from bkonyi and kenzieschmoll and removed request for a team and bkonyi December 11, 2024 00:52
@kenzieschmoll
Copy link
Member

Hopefully with this change users will never have to manually refresh the widget tree!

This definitely gets us closer. Things that still would not be caught are where the state changes on the current page, such as opening a dropdown menu, switching views in a tab controller, etc. I wonder if we could refresh on some fixed cadence (# of frames, every X seconds, etc.) to get us all the way there, but that is out of scope for this PR and we'd need to assess how expensive that may be.

@elliette
Copy link
Member Author

Hopefully with this change users will never have to manually refresh the widget tree!

This definitely gets us closer. Things that still would not be caught are where the state changes on the current page, such as opening a dropdown menu, switching views in a tab controller, etc. I wonder if we could refresh on some fixed cadence (# of frames, every X seconds, etc.) to get us all the way there, but that is out of scope for this PR and we'd need to assess how expensive that may be.

Ahh good point! I won't remove the refresh button then.

@elliette elliette merged commit b48b31b into flutter:master Dec 12, 2024
24 of 25 checks passed
mossmana pushed a commit to mossmana/devtools that referenced this pull request Dec 17, 2024
@elliette @mossmana
Auto-refresh the widget tree on navigation events (flutter#8622)
e8c7b33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @kenzieschmoll