Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inspector V2] Request the reduced widget tree from Flutter #8480

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

elliette
Copy link
Member

Work towards #1423

Uses the fullDetails=false parameter added in flutter/flutter#157309 to request the smaller widget tree.

@elliette elliette requested a review from a team as a code owner October 25, 2024 17:31
@elliette elliette requested review from bkonyi and kenzieschmoll and removed request for a team October 25, 2024 17:31
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this to verify we are getting the smaller tree? Perhaps an inspector text golden test that checks this case?

@elliette
Copy link
Member Author

Is there a way to test this to verify we are getting the smaller tree? Perhaps an inspector text golden test that checks this case?

Good point, added a test case to the integration test (which is using a real app). I've added a check that the JSON object for each node only contains the information we expect for the small tree.

Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall!

@elliette elliette merged commit 0a752c8 into flutter:master Oct 29, 2024
23 checks passed
mossmana pushed a commit to mossmana/devtools that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants