-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inspector V2] Request the reduced widget tree from Flutter #8480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to test this to verify we are getting the smaller tree? Perhaps an inspector text golden test that checks this case?
Good point, added a test case to the integration test (which is using a real app). I've added a check that the JSON object for each node only contains the information we expect for the small tree. |
packages/devtools_app/test/inspector_v2/inspector_integration_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall!
Work towards #1423
Uses the
fullDetails=false
parameter added in flutter/flutter#157309 to request the smaller widget tree.