Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add health checks for breaking changes, changelogs, pubspecs, etc #8314

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakemac53
Copy link
Contributor

Add a health check job that checks various things, such as changelog entries and proper semver.

Would avoid issues such as the one in #8291 where breaking changes are accidentally released in non-breaking versions.

I am not actually sure this works with repos that are a mixture of flutter and dart packages, we might need some extra functionality from the health check tool if this fails on the non-flutter packages.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

@jakemac53 jakemac53 requested a review from a team as a code owner September 9, 2024 19:56
@jakemac53 jakemac53 requested review from bkonyi and removed request for a team September 9, 2024 19:56
@jakemac53 jakemac53 marked this pull request as draft September 9, 2024 19:56
@jakemac53
Copy link
Contributor Author

cc @bkonyi I also see this failure https://github.com/flutter/devtools/actions/runs/10780298465 it looks like there is a transitive dep on a new GitHub action, and those have to be allow listed somehow. Any ideas?

@bkonyi
Copy link
Contributor

bkonyi commented Sep 26, 2024

cc @bkonyi I also see this failure https://github.com/flutter/devtools/actions/runs/10780298465 it looks like there is a transitive dep on a new GitHub action, and those have to be allow listed somehow. Any ideas?

Sorry for the delayed response. I'll be honest, I know nothing about GitHub actions 😬

@jakemac53
Copy link
Contributor Author

@kenzieschmoll do you have any ideas how this check is set up? Maybe something in the admin settings for the repo?

@jakemac53
Copy link
Contributor Author

It looks like it probably is in the settings for the repo, see https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository. We will need an admin to approve of this new action and add it to the list.

Does anybody know who an admin is for this repo? cc @devoncarew @kevmoo ?

@devoncarew
Copy link
Member

Does anybody know who an admin is for this repo? cc @devoncarew @kevmoo ?

For repos in the flutter/ github org, you'll want @Piinks (and possibly others?).

@Piinks
Copy link
Contributor

Piinks commented Sep 26, 2024

@kenzieschmoll is an admin for this repo, I am not familiar with how the github actions are set up here.

@kenzieschmoll
Copy link
Member

I don't have the ability to add a new action, the text field is disabled for me:
Screenshot 2024-09-30 at 2 28 23 PM
@Piinks are you able to add the "peter-evans/find-comment@d0ee7939ee99ba35820c3e58de972e57ff8bb890" action?

@Piinks
Copy link
Contributor

Piinks commented Sep 30, 2024

Same, I also cannot edit the text field. 🤔
Asking the infra folks for advice

@flutter flutter deleted a comment Oct 15, 2024
@flutter flutter deleted a comment Oct 15, 2024
@goderbauer
Copy link
Member

(triage): @Piinks Did the infra people have any advice?

@Piinks
Copy link
Contributor

Piinks commented Dec 19, 2024

(triage): @Piinks Did the infra people have any advice?

Alas, they did not. 😞 Will take a look again in the new year, there may be an obscure setting that is causing this to be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants