remove and inline the use of package:ansi_up (#8601)

* remove and inline the use of package:ansi_up * DCM lints
flutter · Dec 6, 2024 · ee6877a · ee6877a
1 parent 0a77055
commit ee6877a
Show file tree

Hide file tree

Showing 8 changed files with 402 additions and 56 deletions.
diff --git a/packages/devtools_app/lib/src/screens/logging/_message_column.dart b/packages/devtools_app/lib/src/screens/logging/_message_column.dart
@@ -69,7 +69,7 @@ class MessageColumn extends ColumnData<LogData>
                 text: TextSpan(
                   children: [
                     if (hasSummary)
-                      ...processAnsiTerminalCodes(
+                      ...textSpansFromAnsi(
                         // TODO(helin24): Recompute summary length considering ansi codes.
                         //  The current summary is generally the first 200 chars of details.
                         data.summary!,
@@ -78,7 +78,7 @@ class MessageColumn extends ColumnData<LogData>
                     if (hasSummary && hasDetails())
                       TextSpan(text: '  •  ', style: theme.subtleTextStyle),
                     if (hasDetails())
-                      ...processAnsiTerminalCodes(
+                      ...textSpansFromAnsi(
                         detailsComputed ? data.details! : '<fetching>',
                         theme.subtleTextStyle,
                       ),

diff --git a/packages/devtools_app/lib/src/screens/vm_developer/object_inspector/vm_instance_display.dart b/packages/devtools_app/lib/src/screens/vm_developer/object_inspector/vm_instance_display.dart
@@ -165,8 +165,8 @@ class DisplayProvider extends StatelessWidget {
     if (variable.text != null) {
       return SelectableText.rich(
         TextSpan(
-          children: processAnsiTerminalCodes(
-            variable.text,
+          children: textSpansFromAnsi(
+            variable.text ?? '',
             theme.subtleFixedFontStyle,
           ),
         ),

diff --git a/packages/devtools_app/lib/src/shared/console/console.dart b/packages/devtools_app/lib/src/shared/console/console.dart
@@ -183,7 +183,7 @@ class _ConsoleOutputState extends State<_ConsoleOutput>
                   TextSpan(
                     // TODO(jacobr): consider caching the processed ansi terminal
                     // codes.
-                    children: processAnsiTerminalCodes(
+                    children: textSpansFromAnsi(
                       line.text,
                       theme.regularTextStyle,
                     ),

diff --git a/packages/devtools_app/lib/src/shared/console/widgets/display_provider.dart b/packages/devtools_app/lib/src/shared/console/widgets/display_provider.dart
@@ -48,8 +48,8 @@ class _DisplayProviderState extends State<DisplayProvider> {
         menuButtons: _getMenuButtons(context),
         child: Text.rich(
           TextSpan(
-            children: processAnsiTerminalCodes(
-              widget.variable.text,
+            children: textSpansFromAnsi(
+              widget.variable.text!,
               theme.subtleFixedFontStyle,
             ),
           ),