Skip to content

Commit

Permalink
Add a TODO and comment.
Browse files Browse the repository at this point in the history
  • Loading branch information
elliette committed Dec 19, 2024
1 parent fad09b2 commit b1ca6ef
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,12 @@ class InspectorController extends DisposableController
) = _findClosestUnchangedAncestor(previousSelection);
if (closestUnchangedAncestor == null) return inspectorTree.root?.diagnostic;

// TODO(elliette): This might cause a race event that will set this to false
// for a subsequent navigate event. Consider passing the value of
// _refreshingAfterNavigationEvent through the method chain from where the
// navigation event is detected. This would require updating the interface
// of InspectorServiceClient.onForceRefresh, or refactoring to avoid doing
// so.
if (_refreshingAfterNavigationEvent) {
_refreshingAfterNavigationEvent = false;
return closestUnchangedAncestor;
Expand Down

0 comments on commit b1ca6ef

Please sign in to comment.