[Inspector V2] Hide implementation widgets by default (#8647)

flutter · Dec 20, 2024 · 2ffc52c · 2ffc52c
1 parent ba8a14f
commit 2ffc52c
Show file tree

Hide file tree

Showing 15 changed files with 31 additions and 19 deletions.
diff --git a/packages/devtools_app/lib/src/screens/inspector_v2/inspector_controller.dart b/packages/devtools_app/lib/src/screens/inspector_v2/inspector_controller.dart
@@ -247,7 +247,7 @@ class InspectorController extends DisposableController
   /// Whether the implementation widgets are hidden in the widget tree.
   ValueListenable<bool> get implementationWidgetsHidden =>
       _implementationWidgetsHidden;
-  final _implementationWidgetsHidden = ValueNotifier<bool>(false);
+  final _implementationWidgetsHidden = ValueNotifier<bool>(true);
 
   InspectorTreeNode? lastExpanded;
 

diff --git a/packages/devtools_app/test/screens/inspector_v2/inspector_integration_test.dart b/packages/devtools_app/test/screens/inspector_v2/inspector_integration_test.dart
@@ -156,6 +156,9 @@ void main() {
       (WidgetTester tester) async {
         await _loadInspectorUI(tester);
 
+        // Toggle implementation widgets on.
+        await _toggleImplementationWidgets(tester);
+
         // Before hidden widgets are expanded, confirm the HeroControllerScope
         // is hidden:
         final hideableNodeFinder = findNodeMatching('HeroControllerScope');
@@ -207,6 +210,9 @@ void main() {
     ) async {
       await _loadInspectorUI(tester);
 
+      // Toggle implementation widgets on.
+      await _toggleImplementationWidgets(tester);
+
       // Before searching, confirm the HeroControllerScope is hidden:
       final hideableNodeFinder = findNodeMatching('HeroControllerScope');
       expect(hideableNodeFinder, findsNothing);
@@ -239,21 +245,15 @@ void main() {
   ) async {
     await _loadInspectorUI(tester);
 
-    // Give time for the initial animation to complete.
-    await tester.pumpAndSettle(inspectorChangeSettleTime);
+    // Toggle implementation widgets on.
+    await _toggleImplementationWidgets(tester);
 
     // Confirm the hidden widgets are visible behind affordances like "X more
     // widgets".
     expect(find.richTextContaining('more widgets...'), findsWidgets);
 
-    // Tap the "Show Implementation Widgets" button (selected by default).
-    final showImplementationWidgetsButton = find.descendant(
-      of: find.byType(DevToolsToggleButton),
-      matching: find.text('Show Implementation Widgets'),
-    );
-    expect(showImplementationWidgetsButton, findsOneWidget);
-    await tester.tap(showImplementationWidgetsButton);
-    await tester.pumpAndSettle(inspectorChangeSettleTime);
+    // Toggle implementation widgets off.
+    await _toggleImplementationWidgets(tester);
 
     // Confirm that the hidden widgets are no longer visible.
     expect(find.richTextContaining('more widgets...'), findsNothing);
@@ -287,6 +287,10 @@ void main() {
   ) async {
     // Load the Inspector.
     await _loadInspectorUI(tester);
+
+    // Toggle implementation widgets on.
+    await _toggleImplementationWidgets(tester);
+
     await tester.pumpAndSettle(inspectorChangeSettleTime);
     final state =
         tester.state(find.byType(InspectorScreenBody))
@@ -300,14 +304,8 @@ void main() {
         diagnostics.firstWhere((d) => d?.description == 'Text')!;
     expect(textDiagnostic.isCreatedByLocalProject, isTrue);
 
-    // Tap the "Show Implementation Widgets" button (selected by default).
-    final showImplementationWidgetsButton = find.descendant(
-      of: find.byType(DevToolsToggleButton),
-      matching: find.text('Show Implementation Widgets'),
-    );
-    expect(showImplementationWidgetsButton, findsOneWidget);
-    await tester.tap(showImplementationWidgetsButton);
-    await tester.pumpAndSettle(inspectorChangeSettleTime);
+    // Toggle implementation widgets off.
+    await _toggleImplementationWidgets(tester);
 
     // Verify the Text diagnostic node is still in the tree.
     final diagnosticsNow = state.controller.inspectorTree.rowsInTree.value.map(
@@ -505,6 +503,9 @@ void main() {
     ) async {
       await _loadInspectorUI(tester);
 
+      // Toggle implementation widgets on.
+      await _toggleImplementationWidgets(tester);
+
       // Give time for the initial animation to complete.
       await tester.pumpAndSettle(inspectorChangeSettleTime);
 
@@ -596,6 +597,17 @@ void main() {
   });
 }
 
+Future<void> _toggleImplementationWidgets(WidgetTester tester) async {
+  // Tap the "Show Implementation Widgets" button (selected by default).
+  final showImplementationWidgetsButton = find.descendant(
+    of: find.byType(DevToolsToggleButton),
+    matching: find.text('Show Implementation Widgets'),
+  );
+  expect(showImplementationWidgetsButton, findsOneWidget);
+  await tester.tap(showImplementationWidgetsButton);
+  await tester.pumpAndSettle(inspectorChangeSettleTime);
+}
+
 Future<void> _loadInspectorUI(WidgetTester tester) async {
   final screen = InspectorScreen();
   await tester.pumpWidget(

diff --git a/packages/devtools_app/test/test_infra/goldens/codeview_scrollbars.png b/packages/devtools_app/test/test_infra/goldens/codeview_scrollbars.png
diff --git a/..._app/test/test_infra/goldens/integration_inspector_v2_errors_1_initial_load.png b/..._app/test/test_infra/goldens/integration_inspector_v2_errors_1_initial_load.png
diff --git a/...pp/test/test_infra/goldens/integration_inspector_v2_errors_2_error_selected.png b/...pp/test/test_infra/goldens/integration_inspector_v2_errors_2_error_selected.png
diff --git a/...p/test/test_infra/goldens/integration_inspector_v2_hideable_widget_selected.png b/...p/test/test_infra/goldens/integration_inspector_v2_hideable_widget_selected.png
diff --git a/...infra/goldens/integration_inspector_v2_hideable_widget_selected_from_search.png b/...infra/goldens/integration_inspector_v2_hideable_widget_selected_from_search.png
diff --git a/...est_infra/goldens/integration_inspector_v2_implementation_widgets_collapsed.png b/...est_infra/goldens/integration_inspector_v2_implementation_widgets_collapsed.png
diff --git a/...test_infra/goldens/integration_inspector_v2_implementation_widgets_expanded.png b/...test_infra/goldens/integration_inspector_v2_implementation_widgets_expanded.png
diff --git a/...t/test_infra/goldens/integration_inspector_v2_implementation_widgets_hidden.png b/...t/test_infra/goldens/integration_inspector_v2_implementation_widgets_hidden.png
diff --git a/.../devtools_app/test/test_infra/goldens/integration_inspector_v2_initial_load.png b/.../devtools_app/test/test_infra/goldens/integration_inspector_v2_initial_load.png
diff --git a/...devtools_app/test/test_infra/goldens/integration_inspector_v2_select_center.png b/...devtools_app/test/test_infra/goldens/integration_inspector_v2_select_center.png
diff --git a/...s/devtools_app/test/test_infra/goldens/memory/load_offline_data_profile_tab.png b/...s/devtools_app/test/test_infra/goldens/memory/load_offline_data_profile_tab.png
diff --git a/packages/devtools_app/test/test_infra/goldens/memory_diff_empty1.png b/packages/devtools_app/test/test_infra/goldens/memory_diff_empty1.png
diff --git a/packages/devtools_app/test/test_infra/goldens/memory_diff_empty2.png b/packages/devtools_app/test/test_infra/goldens/memory_diff_empty2.png