[Inspector V2] Implementation details remain hidden on tree refresh (#…

…8479)
flutter · Oct 25, 2024 · 0f1efc0 · 0f1efc0
1 parent f71b148
commit 0f1efc0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/devtools_app/lib/src/screens/inspector_v2/inspector_controller.dart b/packages/devtools_app/lib/src/screens/inspector_v2/inspector_controller.dart
@@ -419,9 +419,10 @@ class InspectorController extends DisposableController
 
   Future<void> _recomputeTreeRoot(
     RemoteDiagnosticsNode? newSelection, {
-    bool hideImplementationWidgets = false,
+    bool? hideImplementationWidgets,
   }) async {
     assert(!_disposed);
+    hideImplementationWidgets ??= _implementationWidgetsHidden.value;
     final treeGroups = _treeGroups;
     if (_disposed || treeGroups == null) {
       return;

diff --git a/packages/devtools_app/test/inspector_v2/inspector_integration_test.dart b/packages/devtools_app/test/inspector_v2/inspector_integration_test.dart
@@ -260,6 +260,18 @@ void main() {
           '../test_infra/goldens/integration_inspector_v2_implementation_widgets_hidden.png',
         ),
       );
+
+      // Refresh the tree.
+      final refreshTreeButton = find.descendant(
+        of: find.byType(ToolbarAction),
+        matching: find.byIcon(Icons.refresh),
+      );
+
+      await tester.tap(refreshTreeButton);
+      await tester.pumpAndSettle(inspectorChangeSettleTime);
+
+      // Confirm that the hidden widgets are still not visible.
+      expect(find.richTextContaining('more widgets...'), findsNothing);
     },
   );