Changes to swap rule and to acc_tuner #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to implement the swap rule
```
if evj.value - evi.value < algo["maxdists"][i]
swap_ev_ij!(algo,i,j)
end
```
I changed the default `dist_fun` into `-`, so that the algorithm looks at `algo.dist_fun(evj.value, evi.value)`. In addition, I changed the default `maxdists` to a vector of zeros, so that the default swap rule is simply `evj.value < evi.value`, as suggested by BGP.
I also introduced a vector `acc_tuners` as a field of `MAlgoBGP` so that each chain can have its own value for `acc_tuner`. This allows more control on the algorithm. Ideally, you might want to be more restrictive (i.e., higher `acc_tuner`) on colder chains.
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 52.5% 52.29% -0.21%
==========================================
Files 14 14
Lines 960 960
==========================================
- Hits 504 502 -2
- Misses 456 458 +2
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 209
💛 - Coveralls |
|
can you just let me know when you are done with this? Im planning to move to julia 0.7 in the coming days, so i may wait (or not) depending on that. |
|
OK, I will do this as soon as possible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement the swap rule
I realized I could simply change the default
dist_funinto-, so that the algorithm looks atalgo.dist_fun(evj.value, evi.value)being by default-(evj.value, evi.value)but still being editable by users. In addition, I changed the defaultmaxdiststo a vector of zeros, so that the default swap rule is simplyevj.value < evi.value, as suggested by BGP.I also introduced a vector
acc_tunersas a field ofMAlgoBGPso that each chain can have its own value foracc_tuner. This allows for more control on the algorithm. Ideally, one might want to be more restrictive (i.e., higheracc_tuner) on colder chains.