make tags and filters private for templateSet #335

honmaple · 2023-06-26T05:03:46Z

TemplateSet add tags and filters variable, and remove global variable, RegisterTag and RegisterFilter will change DefaultSet.tags and DefaultSet.filters.
After modification, different function but same name can be added for different templateSet

draganm · 2023-10-20T11:58:15Z

template_sets.go

@@ -68,6 +83,8 @@ func NewSet(name string, loaders ...TemplateLoader) *TemplateSet {
 		name:          name,
 		loaders:       loaders,
 		Globals:       make(Context),
+		tags:          make(map[string]*tag),
+		filters:       make(map[string]FilterFunction),


Gave this a spin - having empty filters leads to panic when redering variables with escaping, since escape filter is not present. Think NewDefaultSet will have to include at least that one!

@draganm It might be a good idea to use newSet instead of NewDefaultSet. Users can only use NewSet which includes all default filters and tags to create a special template set. What do you think of this idea?

Yeah, that works, but as I said, NewDefaultSet has this huge dependency list of things that need to be provided, that it makes is quite niche. Upon reflection, probably just a word of warning in the GoDoc would be probably enough to point people to NewSet

iamcalledrob · 2023-10-25T16:56:04Z

This behaviour would be super useful for a project I'm working on that uses pongo2 internally. I think it's a better, safer design for the package. Ideally there would be no global variables, except for convenience (e.g. defaults)

Currently due to the global nature of registering tags/filters, a user of my package may end up introducing regressions if they themselves use pongo2 as well.

draganm · 2023-10-25T20:43:03Z

I agree about usefulness of this feature - @flosch is there a chance that we can get this merged any time soon? Think at least 3 people are itching to be using it!