Prevent Duplicate Alerts Created #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 25, 2022 20:20
Add function for endpoint that allows frontend to send date to update the respective alert configuration, and also add an update function to update the SQLite table. BCL-7009
Quick renaming of fields from frontend to send to AeroAPI BCK-7009
Add function to check if duplicate alert is trying to be created (that is, if ident, origin, destination, and aircraft type are all the same). If it is do not create the alert and send response to frontend. BCK-7006
fa-wjeng
reviewed
Aug 17, 2022
| @@ -153,10 +174,10 @@ def get_alerts_not_from_app(existing_alert_ids: Set[int]): | |||
| logger.info(f"Making AeroAPI request to GET {api_resource}") | |||
| result = AEROAPI.get(f"{AEROAPI_BASE_URL}{api_resource}") | |||
| if not result: | |||
| return None | |||
| return [] | |||
There was a problem hiding this comment.
minor change in function doc string to indicate empty list return instead of None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent duplicate alerts being created by sending a JSON message indicating that another alert is the same (based off of if the ident, dest, origin, and aircraft type are all the same).
Only commit 3cbd58e has the relevant changes.
BCK-7009