Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/unified schema 2 #1743

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Feat/unified schema 2 #1743

wants to merge 13 commits into from

Conversation

ElenaDiachenko
Copy link
Contributor

@ElenaDiachenko ElenaDiachenko commented Oct 3, 2024

Description

  • Small description

Related issues

Npm releases

n/a

@ElenaDiachenko ElenaDiachenko changed the title Feat/unified schema Feat/unified schema 2 Oct 3, 2024
@Marius456 Marius456 added this to the 1.5 milestone Oct 9, 2024
@locksten locksten self-requested a review October 11, 2024 07:02
Copy link
Collaborator

@locksten locksten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lightning and windows engines have missing renative.engine.json properties.

After migrating, my renative.local.json has double local, which is probably incorrect:

{
    "local": {
        "_meta": {
            "currentAppConfigId": "harness"
        }
    },
    "project": {},
    "_meta": {
        "currentAppConfigId": "harness"
    }
}

{
    "local": {
        "local": {
            "_meta": {
                "currentAppConfigId": "harness"
            }
        },
        "project": {},
        "_meta": {
            "currentAppConfigId": "harness"
        }
    },
    "$schema": ".rnv/schema/renative-1.0.schema.json"
}

@Marius456 Marius456 modified the milestones: 1.5, 1.6 Oct 22, 2024
@Marius456 Marius456 marked this pull request as draft October 23, 2024 06:23
@pauliusguzas pauliusguzas modified the milestones: 1.6, 1.7 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants