Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCCL] - Various improvements #13

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

[NCCL] - Various improvements #13

wants to merge 26 commits into from

Conversation

goliaro
Copy link
Collaborator

@goliaro goliaro commented Jan 12, 2023 •
edited
Loading

This PR introduces various improvements in the process of cross-compiling Legion/NCCL:

  • Download pre-built NCCL libraries, instead of compiling from scratch, and package the relevant binaries into a tarball.
  • Fix issue related to nested folders within compiled Legion / NCCL tarballs
  • Precompile one version of Legion for each of the following Python versions: 3.7, 3.8, 3.9, 3.10
  • Use earliest patch version of CUDA to prevent conflicts with CUDA version installed on user machine
  • Only use major and minor CUDA / Python versions in pre-compiled binary URLs
  • Add shellcheck

@goliaro goliaro changed the title [NCCL] - Download nccl instead of building from source [NCCL] - Various improvements Jan 28, 2023
@goliaro goliaro marked this pull request as ready for review January 29, 2023 07:34
@goliaro goliaro mentioned this pull request Jan 29, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@goliaro