Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL-577 Add Instance Cost Per Hour (Azure) #1184

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

nia-vf1
Copy link
Contributor

@nia-vf1 nia-vf1 commented Feb 17, 2023

Description

[Describe what this change achieves]

Issues Resolved

[List any existing issues this PR resolves]

Contribution Check List

  • All tests pass.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable
  • New functionality has been documented in CHANGELOG.MD

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

1 Error
🚫 cost/azure/unit_economics/azure_instance_cost_per_hour/README.md
README.md has problems with how credential permissions are presented:

Azure permissions missing or incorrectly formatted. Please make sure Azure permissions begin with a list item like the following:

- [**Azure Resource Manager Credential**](https://docs.flexera.com/flexera/EN/Automation/ProviderCredentials.htm#automationadmin_109256743_1124668) (*provider=azure_rm*) which has the following permissions:

3 Warnings
⚠️ Github Pull Request
Pull Request is missing READY-FOR-REVIEW label. Please add this label if this Pull Request is ready for review.

Please note that this warning may be a false positive if you've added the label after Dangerfile tests were run, since adding labels does not trigger them to run again. In these cases, simply ignore this warning.

⚠️ cost/azure/unit_economics/azure_instance_cost_per_hour/azure_instance_cost_per_hour.pt
Policy Template has indentation issues. Code should be indented with 2 spaces inside each do/end block, info() block, and EOS block, with additional spacing for nested blocks as appropriate:

Line 58: Expected indentation of 2 spaces but found 4 spaces.
Line 59: Expected indentation of 2 spaces but found 4 spaces.
Line 388: Expected indentation of at least two spaces within code/text block.
Line 389: Expected indentation of at least two spaces within code/text block.
Line 390: Expected indentation of at least two spaces within code/text block.
Line 391: Expected indentation of at least two spaces within code/text block.

⚠️ cost/azure/unit_economics/azure_instance_cost_per_hour/azure_instance_cost_per_hour.pt
Detected new request datasource(s) in Policy Template file. Please verify the README.md has any new permissions that may be required.

Generated by 🚫 Danger

@nia-vf1 nia-vf1 changed the title POL-577 - Add Instance Cost Per Hour (Azure) POL-577 Add Instance Cost Per Hour (Azure) Feb 17, 2023
@bryankaraffa bryankaraffa marked this pull request as draft April 17, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant