Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup experience software API #22507

Merged
merged 27 commits into from
Oct 8, 2024

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Sep 30, 2024

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests

@dantecatalfamo dantecatalfamo changed the base branch from main to feat-setup-experience September 30, 2024 17:51
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 81.17647% with 32 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-setup-experience@0a4107c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/setup_experience.go 89.06% 7 Missing and 7 partials ⚠️
server/service/setup_experience.go 50.00% 8 Missing and 2 partials ⚠️
ee/server/service/setup_experience.go 46.66% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##             feat-setup-experience   #22507   +/-   ##
========================================================
  Coverage                         ?   65.09%           
========================================================
  Files                            ?     1528           
  Lines                            ?   118662           
  Branches                         ?     3548           
========================================================
  Hits                             ?    77238           
  Misses                           ?    34247           
  Partials                         ?     7177           
Flag Coverage Δ
backend 66.36% <81.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo marked this pull request as ready for review October 3, 2024 18:48
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner October 3, 2024 18:48
Copy link
Contributor

@jahzielv jahzielv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just 1 small nit

Copy link
Contributor

@jahzielv jahzielv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dantecatalfamo dantecatalfamo merged commit ab1b66e into feat-setup-experience Oct 8, 2024
20 of 21 checks passed
@dantecatalfamo dantecatalfamo deleted the setup-experience-software-api branch October 8, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants