Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for targeting all li's on page #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

AwlO
Copy link

@AwlO AwlO commented Mar 28, 2017

Fix for issue where all first li's across the page get an active class when running showTabs

@DimaSavchenko
Copy link
Contributor

Hi @AwlO !
Could you explain what problem does your solution fix?

@germancasares
Copy link

When you have more li's with the class active on your page, it doesn't take into account which are from tabs and which aren't. This solutions fix that, so only search for active li inside the tabs.

@AwlO
Copy link
Author

AwlO commented Aug 10, 2017

Late response, but yeah, exactly as @german95n said

@jorisvm
Copy link

jorisvm commented Dec 5, 2017

I just came up with a similar fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants