WIP: Refine update progress reports #443
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The groups' stats were being computed without taking into account the version of the group, so the information could be mistakenly interpreted by users (e.g. having instances in an "update complete" state but that being for an older version because the instances stopped querying for updates for a while). So this patch changes the query that performs the stats in order to show exactly how many instances are up to date or updating to the current version.
The update progress report has been changed to be more accurate, so this patch also updates the group's charts to reflect that change.
Because without a version, the group's report is not accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working on this PR to make the group's stats a bit more accurate to what the user perceives: the issue is that we are gathering any instances with a certain state (downloaded/downloading/update-granted/error), regardless of whether they are updated or have updated to the version that the group declares.
This may hint, for example, that there are 3 instances downloading (the group's version), when they may be actually downloading a previous version, if the group's channel has just updated to a newer package.
Also, instances that have pinged the group and are in the group's version, will have no status change, and this showed up as "undefined" but they're actually instances that are up to date.
Another thing that's added is that there was no way to show instances that have timed out, and this patch includes those.
Important: This PR is still missing some important things beyond the charts, like having a way to filter by "time out", etc. otherwise the instances list view will not be accurate.
So this is WIP ATM.