New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename field name in UsedStateTrace #90

Merged

ZanCorDX merged 1 commit into flashbots:develop from nikoseven:used_state_trace_naming

Aug 8, 2024

Contributor

nikoseven commented Jul 31, 2024 •

edited

Loading

📝 Summary

Rename read_set/write_set to read_slot_values/written_slot_values

💡 Motivation and Context

As discussed in #58, we renamed the fields to make it more descriptive and clear with the coming fields we are going to add.

✅ I have completed the following steps:

Run make lint
Run make test
Added tests (if applicable)


          Rename field name in UsedStateTrace

4a0f0f5

nikoseven requested review from dvush and ZanCorDX as code owners

July 31, 2024 02:31

ZanCorDX approved these changes

View reviewed changes

ZanCorDX merged commit 857221a into flashbots:develop

2 checks passed

github-actions bot commented Aug 8, 2024

Benchmark results for `4a0f0f5`

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/4a0f0f5-f1262ae/report/index.html


Date (UTC)	2024-08-08T18:03:57+00:00
Commit	`4a0f0f5147c8ee60b6c83f85786bdec983fbb7eb`
Base SHA	`f1262ae538e635325fd3e05cfcef4c757c86142c`

Significant changes

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet