Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playground integration #69

Merged
merged 42 commits into from
Aug 5, 2024
Merged

Conversation

ferranbt
Copy link
Contributor

@ferranbt ferranbt commented Jul 17, 2024

📝 Summary

This PR implements and integration test using the builder-playground:

  • It creates a playground.rs utility library to interact with the playground. In this first iteration, most of the variables (e.g. private keys, urls, etc...) are hardcoded.
  • It creates a simple integration test that ensures that a transaction sent to the EL gets mined by the rbuilder and included on the block through mev-boost-relay.
  • It runs the integration test in CI after the unit tests have passed.

The integration test works directly with the rbuilder compiled binary.

💡 Motivation and Context


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@ferranbt ferranbt force-pushed the feat/playground-integration branch from 636f09b to 614d20b Compare July 17, 2024 18:05
Copy link

github-actions bot commented Jul 18, 2024

Benchmark results for 1172987

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/1172987-21fea73/report/index.html

Date (UTC) 2024-08-05T17:45:28+00:00
Commit 117298711f27a0fbef18b20e3a3485d35333a4a1
Base SHA 21fea738fc06cf0832a5cedbcc49eb9211c3a68c

Significant changes

None

@ferranbt ferranbt changed the title [WIP] Add playground integration Add playground integration Jul 30, 2024
# This steps fails if the test fails early and the playground logs dir has not been created
if: ${{ failure() }}
run: |
mv integration_logs /tmp/playground/logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this step needed? couldn't you directly upload the folder as artifact without moving?

rbuilder.toml Outdated
telemetry_port = 6060
telemetry_ip = "0.0.0.0"

chain = "/Users/ferranbt/go/src/github.com/flashbots/builder-playground/local-testnet/genesis.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be ideal if we could put the local chain data into ~/.builder-playground/... where the other builder playground stuff is located in. that way there could be a single example config that works for everyone.

@metachris metachris merged commit 52fea31 into develop Aug 5, 2024
3 checks passed
@metachris metachris deleted the feat/playground-integration branch August 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants