-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playground integration #69
Conversation
636f09b
to
614d20b
Compare
Benchmark results for
|
Date (UTC) | 2024-08-05T17:45:28+00:00 |
Commit | 117298711f27a0fbef18b20e3a3485d35333a4a1 |
Base SHA | 21fea738fc06cf0832a5cedbcc49eb9211c3a68c |
Significant changes
None
# This steps fails if the test fails early and the playground logs dir has not been created | ||
if: ${{ failure() }} | ||
run: | | ||
mv integration_logs /tmp/playground/logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this step needed? couldn't you directly upload the folder as artifact without moving?
rbuilder.toml
Outdated
telemetry_port = 6060 | ||
telemetry_ip = "0.0.0.0" | ||
|
||
chain = "/Users/ferranbt/go/src/github.com/flashbots/builder-playground/local-testnet/genesis.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be ideal if we could put the local chain data into ~/.builder-playground/...
where the other builder playground stuff is located in. that way there could be a single example config that works for everyone.
📝 Summary
This PR implements and integration test using the builder-playground:
The integration test works directly with the
rbuilder
compiled binary.💡 Motivation and Context
✅ I have completed the following steps:
make lint
make test