Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed internal compiler error. addili: illegal IL_TYPE(opc) #859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikhil-mk
Copy link

@nikhil-mk nikhil-mk commented Jan 23, 2020

Accessing the correct index

Change-Id: I8a8103f71266366bfb32c658df395ce61e3065f8

Fixes issue #860
@gklimowicz @sscalpone

…ing the correct index

Change-Id: I8a8103f71266366bfb32c658df395ce61e3065f8
@kiranchandramohan
Copy link
Collaborator

Is this a duplicate of #844 and the fix in #845 ?

@nikhil-mk
Copy link
Author

Is this a duplicate of #844 and the fix in #845 ?

No.

@kiranchandramohan
Copy link
Collaborator

kiranchandramohan commented Jan 23, 2020

@nikhil-mk this was the first approach I thought of when trying to fix the issue #844. But then I realised that the index (=4) is correct if the entry for half-precision is there at index (=3) in the aif array in exp_bran in exp_ftn.cpp. The fix in #845 adds that entry.

@mleair
Copy link
Contributor

mleair commented Jan 23, 2020

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants