Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds WebP Quality Config #3672

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PoneyClairDeLune
Copy link

@PoneyClairDeLune PoneyClairDeLune commented Jul 19, 2024

Like #3285, this PR aims at introducing a quality config into Flameshot, allowing users to customize the quality of the WebP image emitted by Flameshot.

However during the testing of this PR, I've noticed a few problems with the output emitted from the Qt5 ImageFormat plugin.

  • The resulting files produced by Flameshot are inferior compared to ones emitted by cwebp with the exact same quality value.
  • The Qt5 ImageFormat plugin doesn't allow saving as lossless WebP, which is a far superior lossless image format than PNG, allowing on average 27% size reduction.
  • Said plugin also doesn't allow customizing effort value used to optimize the resulting image.

So perhaps, for the easier route, there should be a config option, allowing Flameshot to automatically execute a command to optimize the final image from PNG. Or maybe integrate libwebp or libvips directly?

@mmahmoudian mmahmoudian added the Needs Decision This is something that should be discussed by community label Jul 19, 2024
@mmahmoudian
Copy link
Member

mmahmoudian commented Jul 19, 2024

@PoneyClairDeLune Thanks for the PR.

@jack9603301 What is your opinion about this question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Decision This is something that should be discussed by community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants