Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make flame_3d work with latest stable #3387

Merged
merged 6 commits into from
Dec 14, 2024

Conversation

wolfenrain
Copy link
Contributor

@wolfenrain wolfenrain commented Dec 13, 2024

Description

Fixes up the changes needed in flame_3d to work with the latest version of Flutter stable.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@wolfenrain wolfenrain changed the title fix: make flame_3d work with latest stable Fix: make flame_3d work with latest stable Dec 13, 2024
@wolfenrain wolfenrain changed the title Fix: make flame_3d work with latest stable fix: Make flame_3d work with latest stable Dec 13, 2024
.github/workflows/cicd.yml Outdated Show resolved Hide resolved
@wolfenrain wolfenrain marked this pull request as draft December 13, 2024 22:00
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfenrain wolfenrain marked this pull request as ready for review December 14, 2024 10:56
@wolfenrain wolfenrain merged commit f940d3f into main Dec 14, 2024
9 checks passed
@wolfenrain wolfenrain deleted the fix-make-graphics-device-work-with-latest-stable branch December 14, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants