Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix for py3.12 #3461

Closed
wants to merge 2 commits into from
Closed

quick fix for py3.12 #3461

wants to merge 2 commits into from

Conversation

tavallaie
Copy link

@tavallaie tavallaie commented May 26, 2024

adding genism@da2f388 for supporting python 3.12

Solving #3438

https://blog.techbend.io/overcoming-the-hazm-compatibility-challenge-with-python-312

@helpmefindaname
Copy link
Collaborator

Hi @tavallaie
thank you for taking kind of this issue, but I disagree that this should be merged into libraries.
The root issue lies in gensim not having released the fixes that are on their current develop branch. The fix to this is, that gensim needs to release a new version that is stable, which they are also planning to do soon.
Until then, nothing prevents you from using flair by running pip install flair git+https://github.com/piskvorky/gensim.git@da2f388 or any of the other solutions suggested here.
Pinning a version within a library would be bad, as it would force everyone to use that specific version, no matter if they are using python3.12 or were going for older python3.8

@david-waterworth
Copy link
Contributor

This also doesn't have anything to do with Python 3.12 either as far as I understand. The issue is with gensim using a deprecated scipy function but not setting the requirements correctly (if you knowingly use a deprecated function you should at least set an upper bound on the library you're using until you're ready to fix) - it occurs on all version of python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants