Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining block size in UltravoxConfig, and solving assertions #157

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

saeeddhqan
Copy link
Contributor

Correcting assertion mismatches when initializing audio tower, and defining block size in UltravoxConfig explicitly.

Copy link
Contributor

@farzadab farzadab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Feel free to merge after removing the exclude_key function which is now unnecessary.

ultravox/model/ultravox_config_test.py Outdated Show resolved Hide resolved
@saeeddhqan
Copy link
Contributor Author

@farzadab thank you for helping me out. The work is ready to be merged.

@farzadab farzadab merged commit 6f8f255 into fixie-ai:main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants