-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio streaming training with masking #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Saeed. I left some comments.
It would be ideal to add some tests, for example to make sure the structure of the mask matches what we expect. If you can think of another test feel free to add one.
I know the repo doesn't have many tests, but we'd like to change that.
@farzadab Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I left a few nit comments.
Please make sure to run just format
to run formatting and use just test
to make sure the tests pass.
Co-authored-by: Farzad Abdolhosseini <[email protected]>
@farzadab, I utilized 'just test', and 'just format', and corrected mentioned issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the tests pass it LGTM. Thanks Saeed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like just test
failed since mypy
is complaining.
I proposed the solution for two of the issues. The last one I couldn't figure out at a glance why the value could be None, but it should be easy to figure out with the code editor's help.
Co-authored-by: Farzad Abdolhosseini <[email protected]>
Co-authored-by: Farzad Abdolhosseini <[email protected]>
@farzadab solved. |
By utilizing a mask, we can simulate audio streaming.