Extend audio ds_tool #113
Open
Extend audio ds_tool #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juberti
reviewed
Sep 18, 2024
ultravox/tools/ds_tool/ds_tool.py
Outdated
| sentence = sample[self.asr_column_name] | ||
| translation = sample[self.translation_column_name] | ||
|
|
||
| if not isinstance(audio, dict) or "array" not in audio: |
There was a problem hiding this comment.
Might be able to handle this automatically by using ds_split.cast_column to Audio. (Note also that this doesn't exist in the combine operation below)
There was a problem hiding this comment.
Hm, actually, i think if array isn't in audio, it'll just throw a key error (without the check), which should be fine in this case. I'm hesitant to stack more map operations than necessary because it takes a lot of time to process large datasets.
juberti
reviewed
Oct 18, 2024
| @dataclasses.dataclass | ||
| class AudioExtensionTask: | ||
| audio_column_name: str = simple_parsing.field(default="audio", alias="-a") | ||
| text_column_name: str = simple_parsing.field(default="sentence", alias="-A") |
There was a problem hiding this comment.
Suggested change
| text_column_name: str = simple_parsing.field(default="sentence", alias="-A") | |
| text_column_name: str = simple_parsing.field(default="sentence", alias="-t") |
juberti
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an extend audio task in ds_tool to create longer audio segments for eval