Add Asia (Tokyo) Region Support & Parallel Benchmark Optimization #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split into pre-warm and run-benchmarks jobs - Use matrix for regions and media types - Set max-parallel to 20 for GitHub Free tier
- Allows setting 1-20 parallel jobs, with 1 for sequential execution
|
Thanks for the PR, will take a look at this this week |
juberti
reviewed
Oct 8, 2024
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| region: [sea, iad, cdg, nrt] |
There was a problem hiding this comment.
I think it's fine to parallelize region since those are separate runners, but parallelizing medium will put additional load on the runners which we know can affect the measurements. I'd suggest either keeping each medium as a serial task or having a separate max-parallel config that we can use to experimentally roll this out.
There was a problem hiding this comment.
Also, I turned up in Singapore (sin) vs Narita for broader Asia coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokyo Region Support & Parallel Benchmark Optimization
Key Changes
Performance Enhancements
Workflow Optimization
BEFORE: Sequential execution
10m 30sAFTER: 10 jobs running in parallel
2m 25sAdditional Notes
nrtregion is needed