Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved layout of reports #5055

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

sevtor
Copy link
Contributor

@sevtor sevtor commented Nov 15, 2024

The Report module is updated to allow the creation of reports with clickable references and better layout of pdf reports.

…ickable references and better layout of pdf reports.
@sevtor sevtor changed the title ImproThe Report module is updated to allow the creation of reports with cl… Improved layout of reports Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 132 lines in your changes missing coverage. Please review.

Project coverage is 35.57%. Comparing base (707e8a4) to head (4872aeb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/Report/ReportParserGenerate.php 58.16% 123 Missing ⚠️
app/Report/ReportHtmlImage.php 0.00% 4 Missing ⚠️
app/Report/ReportHtmlTextbox.php 94.73% 2 Missing ⚠️
app/Report/ReportPdfTextBox.php 93.33% 2 Missing ⚠️
app/Report/PdfRenderer.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5055      +/-   ##
============================================
+ Coverage     35.32%   35.57%   +0.24%     
- Complexity    11405    11533     +128     
============================================
  Files          1179     1179              
  Lines         47859    48206     +347     
============================================
+ Hits          16905    17147     +242     
- Misses        30954    31059     +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sevtor sevtor mentioned this pull request Nov 15, 2024
@kiwi3685
Copy link
Contributor

Wouldn't this be better produced as an add-on module?
My understanding of older issues discussed here suggests that the current report system is to move in a completely different direction, so incremental changes like this are not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants