1931 Canadian Census #4875
Merged
1931 Canadian Census #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding 1931
1931 Canadian Census
fisharebest
reviewed
Sep 18, 2023
fisharebest
reviewed
Sep 18, 2023
|
Could you also add/update the corresponding test scripts?
They should be pretty straightforward. Just look at one of the other test scripts. Thanks! |
|
sorry, I didn't know about the test scripts.. will work on that, then uploaded and issue a PR for it ASAP |
Added some missing lines and re-worded the description for the last couple of columns
removed brackets from two descriptions to conform with rest of the column descriptions
Fix spacing
Added info for Census of Canada Test
Added two more Nationalities for Census
removing tabs and replaced with spaces
forgot to add line for 1891 census
change language
Fixed Typo
added missing .
Codecov Report
@@ Coverage Diff @@
## main #4875 +/- ##
============================================
+ Coverage 30.97% 31.06% +0.08%
- Complexity 11377 11379 +2
============================================
Files 1169 1170 +1
Lines 47887 47929 +42
============================================
+ Hits 14835 14890 +55
+ Misses 33052 33039 -13
|
|
Thanks! This will be included in the next release. |
fisharebest
added a commit
that referenced
this pull request
Sep 21, 2023
* Update CensusOfCanada.php Adding 1931 * Create CensusOfCanada1931.php 1931 Canadian Census * Update CensusOfCanada1931.php * Update CensusOfCanada1931.php * Create CensusOfCanadaTest1931.php * Delete tests/app/Census/CensusOfCanadaTest1931.php * Create CensusOfCanada1931Test.php * Update CensusOfCanada1931.php Added some missing lines and re-worded the description for the last couple of columns * Update CensusOfCanada1931.php removed brackets from two descriptions to conform with rest of the column descriptions * Update CensusOfCanada1931Test.php * Update CensusOfCanada1931Test.php Fix spacing * Update CensusOfCanadaTest.php Added info for Census of Canada Test * Update CensusColumnNationality.php Added two more Nationalities for Census * Update CensusOfCanada1931Test.php removing tabs and replaced with spaces * Update CensusOfCanadaTest.php forgot to add line for 1891 census * Update CensusOfCanadaTest.php change language * Update CensusOfCanada1931.php Fixed Typo * Update CensusOfCanada1931Test.php added missing . * Update CensusOfCanada1931Test.php * Update CensusOfCanada1931.php * Update CensusColumnNationality.php --------- Co-authored-by: Greg Roach <[email protected]>
ddrury
pushed a commit
to ddrury/webtrees
that referenced
this pull request
Nov 27, 2024
* Update CensusOfCanada.php Adding 1931 * Create CensusOfCanada1931.php 1931 Canadian Census * Update CensusOfCanada1931.php * Update CensusOfCanada1931.php * Create CensusOfCanadaTest1931.php * Delete tests/app/Census/CensusOfCanadaTest1931.php * Create CensusOfCanada1931Test.php * Update CensusOfCanada1931.php Added some missing lines and re-worded the description for the last couple of columns * Update CensusOfCanada1931.php removed brackets from two descriptions to conform with rest of the column descriptions * Update CensusOfCanada1931Test.php * Update CensusOfCanada1931Test.php Fix spacing * Update CensusOfCanadaTest.php Added info for Census of Canada Test * Update CensusColumnNationality.php Added two more Nationalities for Census * Update CensusOfCanada1931Test.php removing tabs and replaced with spaces * Update CensusOfCanadaTest.php forgot to add line for 1891 census * Update CensusOfCanadaTest.php change language * Update CensusOfCanada1931.php Fixed Typo * Update CensusOfCanada1931Test.php added missing . * Update CensusOfCanada1931Test.php * Update CensusOfCanada1931.php * Update CensusColumnNationality.php --------- Co-authored-by: Greg Roach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Canadian 1931 Census is digitized and starting to be seen online at Ancestry or the Canadian Archives for download. Adding that year to webtrees.