Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of map provider with missing Api key #4760

Closed
wants to merge 4 commits into from

Conversation

ddrury
Copy link
Contributor

@ddrury ddrury commented Feb 19, 2023

fixs #4758 (now closed)

Applies to map providers that are enabled and require an api key but the key has been omitted.

For users without Admin permissions, previously for the offending provider an exception was raised which blocked access to all the maps. Now the offending provider is silently omitted from the list of available providers and an entry in the error log is made.

For Admin users an exception is raised with a link to the offending providers configuration page. (same as previously)

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 35.32%. Comparing base (e873f43) to head (d0ca5b3).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
app/Services/LeafletJsService.php 0.00% 14 Missing ⚠️
app/Module/ModuleMapProviderTrait.php 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4760   +/-   ##
=========================================
  Coverage     35.32%   35.32%           
+ Complexity    11405    11401    -4     
=========================================
  Files          1179     1179           
  Lines         47859    47850    -9     
=========================================
  Hits          16905    16905           
+ Misses        30954    30945    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddrury ddrury changed the title Improve detection of missing Api key Improve detection of map provider with missing Api key Feb 19, 2023
@ddrury ddrury force-pushed the Fix_map_providers branch 9 times, most recently from d9a8eda to b3ff7c0 Compare February 20, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant