Fix: #5054 - do not require dummy search value for new advanced-searc…

…h fields
fisharebest · Nov 15, 2024 · 707e8a4 · 707e8a4
1 parent 94582e9
commit 707e8a4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/app/Http/RequestHandlers/SearchAdvancedAction.php b/app/Http/RequestHandlers/SearchAdvancedAction.php
@@ -40,10 +40,9 @@ public function handle(ServerRequestInterface $request): ResponseInterface
         $fields      = Validator::parsedBody($request)->array('fields');
         $modifiers   = Validator::parsedBody($request)->array('modifiers');
         $other_field = Validator::parsedBody($request)->string('other_field');
-        $other_value = Validator::parsedBody($request)->string('other_value');
 
-        if ($other_field !== '' && $other_value !== '') {
-            $fields[$other_field] = $other_value;
+        if ($other_field !== '') {
+            $fields[$other_field] = '';
         }
 
         return redirect(route(SearchAdvancedPage::class, [

diff --git a/resources/views/search-advanced-page.phtml b/resources/views/search-advanced-page.phtml
@@ -44,14 +44,10 @@ use Illuminate\Support\Collection;
                 <?= I18N::translate('Add more fields') ?>
             </div>
 
-            <div class="col-sm-3 wt-page-options-value">
+            <div class="col-sm-6 wt-page-options-value">
                 <?= view('components/select', ['name' => 'other_field', 'selected' => '', 'options' => ['' => ''] + $other_fields]) ?>
             </div>
 
-            <div class="col-sm-3 wt-page-options-value">
-                <input type="text" class="form-control" name="other_value">
-            </div>
-
             <div class="col-sm-3 wt-page-options-value">
             </div>
         </div>