Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bluesky share link to the github action bot merging message, solve issue #91497 #92543

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

eniafou
Copy link
Contributor

@eniafou eniafou commented Dec 28, 2024

Addresses #91497

@eniafou
Copy link
Contributor Author

eniafou commented Dec 28, 2024

Hey, this PR addresses #92543.
Can anyone review it please?
@Roshanjossey ?

@Roshanjossey
Copy link
Member

Hi @eniafou, some comments I had while reviewing previous PRs for the same change is relevant here. So, I'll link it.

https://github.com/firstcontributions/first-contributions/pull/92235/files
#91518

if this is not clear, let me know

@eniafou
Copy link
Contributor Author

eniafou commented Dec 29, 2024

Hi @Roshanjossey, thank you for the review. I have implemented the suggested changes.
Can you please take a second look?
Also, do you have any ressources or videos explaining how code reviews in Github work because I am finding them a little confusing read.

@Roshanjossey
Copy link
Member

changes looks good now @eniafou. I'm merging.

For documentation on code reviews, checkout https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews and https://github.com/mawrkus/pull-request-review-guide

Also, to re-iterate what I mentioned above, the way I did review in this PR is not the standard way. Normally you would see comments associated with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants