Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: diffrent postgres versions in main container and backup Job #71

Merged
merged 3 commits into from
Jun 30, 2024

Conversation

schmoaaaaah
Copy link
Contributor

If the postgres version in alpine repo mismatches the one of the main container the dump fails.
can be tested with values:

firefly-db:
    image:
        repository: postgres
        tag: 16.3-alpine

possible problem: if main image is not alpine and backup destination is http the curl install fails

@schmoaaaaah schmoaaaaah requested a review from JC5 as a code owner June 28, 2024 19:36
@JC5
Copy link
Member

JC5 commented Jun 29, 2024

So what will that do when it goes to the new version? Postgres isn't known for its backwards compatibility.

Edit: never mind, I think i see what you try to do. Check out the linting errors please.

@JC5 JC5 merged commit 6561d87 into firefly-iii:main Jun 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants