-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust update to 1.83 #4935
Rust update to 1.83 #4935
Changes from 1 commit
40f3369
6bfe050
fd6bb6f
38f5ead
a9fe92c
1d09f16
12582ac
1010963
46e608c
13a5ad9
536d7e2
f9ed2df
5eb533f
6a9c37b
79257c0
e4f6e5a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
cargo-udeps
to devctr
From: Jonathan Woollett-Light <[email protected]> Adds `cargo-udeps` and the Rust `nightly` toolchain to support it, to dev container. Signed-off-by: Jonathan Woollett-Light <[email protected]> Co-authored-by: Patrick Roy <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,6 +119,7 @@ RUN curl https://sh.rustup.rs -sSf | sh -s -- -y --profile minimal --default-too | |
&& NIGHTLY_TOOLCHAIN=$(rustup toolchain list | grep nightly | tr -d '\n') \ | ||
&& rustup component add rust-src --toolchain "$NIGHTLY_TOOLCHAIN" \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is it needed? any rough estimate how much space it takes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the static analysis thingy uses -Zbuild_std, to compile the standard library as non-PIE, and for that we need to have the source of the standard library around. Its 28.8MB |
||
&& rustup target add "$ARCH"-unknown-linux-musl --toolchain "$NIGHTLY_TOOLCHAIN" \ | ||
&& cargo +"$NIGHTLY_TOOLCHAIN" install cargo-udeps \ | ||
\ | ||
&& apt-get update \ | ||
&& apt-get -y install --no-install-recommends \ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think you don't need the
tr -d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do, otherwise the interpolation of $NIGHTLY_TOOLCHAIN into the
cargo +(bla) install
fails because of a newline in the middleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that I'm thinking about it, maybe that was in python...