Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visualization scripts for A/B tests #4923

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ShadowCurse
Copy link
Contributor

Changes

Save A/B test fails into test_results directory and add scripts to combine and plot this data.

Reason

Better A/B testing experience.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@ShadowCurse ShadowCurse requested a review from roypat November 21, 2024 17:09
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (1320786) to head (8163526).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4923   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         251      251           
  Lines       28061    28061           
=======================================
  Hits        23597    23597           
  Misses       4464     4464           
Flag Coverage Δ
5.10-c5n.metal 84.66% <ø> (ø)
5.10-m5n.metal 84.65% <ø> (ø)
5.10-m6a.metal 83.96% <ø> (ø)
5.10-m6g.metal 80.77% <ø> (ø)
5.10-m6i.metal 84.64% <ø> (+<0.01%) ⬆️
5.10-m7g.metal 80.77% <ø> (ø)
6.1-c5n.metal 84.66% <ø> (ø)
6.1-m5n.metal 84.64% <ø> (ø)
6.1-m6a.metal 83.95% <ø> (ø)
6.1-m6g.metal 80.77% <ø> (ø)
6.1-m6i.metal ?
6.1-m7g.metal 80.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ShadowCurse ShadowCurse force-pushed the ab_test_parsing branch 2 times, most recently from 1610ca6 to 507711b Compare November 22, 2024 13:01
Save A/B test fails to be able to do offline analysis.

Signed-off-by: Egor Lazarchuk <[email protected]>
Add scripts for combining and plotting results of A/B runs.
Move all A/B related scripts to the tools/ab

Signed-off-by: Egor Lazarchuk <[email protected]>
Update links in the docs with new ab_test.py location

Signed-off-by: Egor Lazarchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant