Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmm: Introduce riscv64 architecture #4754

Conversation

TimePrinciple
Copy link

Introduce riscv64 architecture.

Changes

Introduce riscv64 architecture support for vmm module.

Reason

Enable firecracker to work on RISC-V 64-bit platforms.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Introduce logic needed to create cpu node for `riscv64` architecture.

Signed-off-by: Ruoqing He <[email protected]>
@TimePrinciple TimePrinciple marked this pull request as draft August 29, 2024 07:08
Introduce a minimum vm layout with essential devices and definitions.

Signed-off-by: Ruoqing He <[email protected]>
@zulinx86
Copy link
Contributor

zulinx86 commented Sep 2, 2024

Hello @TimePrinciple ,
Thank you for opening this PR.

Sorry, but we are not planning to support this feature into Firecracker at least in the near future, because we don't have RISC-V hardware in our testing infra to test the functionality continuously and we have not received much valid business use cases for it.

If you (or viewers) have a specific use case, could you share it with us? Based on the inputs, we may reconsider its validity :)

Thank you for your understanding.

@zulinx86
Copy link
Contributor

Hello,

We are closing this issue for now because it is not currently planned.
We will come back to this PR if we receive enough business use cases for RISC-V support.

Thank you for your effort and understanding.

@zulinx86 zulinx86 closed this Sep 18, 2024
@TimePrinciple
Copy link
Author

Hello,

We are closing this issue for now because it is not currently planned. We will come back to this PR if we receive enough business use cases for RISC-V support.

Thank you for your effort and understanding.

Sorry for my late response, I will continue to develop RISC-V architecture support until it is accepted by firecracker team. I wonder would it be a troube to remain opened as a draft :)

@zulinx86
Copy link
Contributor

Yes, we can keep this PR opened as a draft :)
We won't be able to merge it into main without valid business use case, but we may be able to merge it into a feature branch.

Thanks.

@zulinx86 zulinx86 reopened this Sep 18, 2024
@zulinx86 zulinx86 added the Type: Enhancement Indicates new feature requests label Sep 18, 2024
@TimePrinciple
Copy link
Author

Yes, we can keep this PR opened as a draft :) We won't be able to merge it into main without valid business use case, but we may be able to merge it into a feature branch.

Thanks.

How very kind, that's exactly what I'm expecting at this stage. I will keep developing and updating this work in a feature branch, and I believe this will be picked up one day by main branch when RISC-V is mature enough.

I'm currently working on supporting rust-vmm crates on RISC-V, and I will get back to this work when they are finished. And repurpose this PR to another branch by that time :)

@zulinx86
Copy link
Contributor

We really appreciate your passion and effort to contribute to Firecracker!
And I really hope that RISC-V gets mature and many cloud vendors adopts it 🚀
Thanks!

@TimePrinciple TimePrinciple closed this by deleting the head repository Sep 25, 2024
@TimePrinciple
Copy link
Author

Works migrated to #4819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants