Configure the network namespace before executing jailer #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protochron
force-pushed
the
jailer_cni_network
branch
2 times, most recently
from
99ec273 to
4c36613
Compare
|
Not quite sure why the root tests would fail on different architectures 🤔 |
Right now there is a bug when trying to start a Firecracker VM with jailer using a CNI where the VM is never joined to the correct network namespace. This is because in its current form, the CNI execution occurs when `fcinit.SetupNetwork` runs, which occurs _after_ the jailer has already created a chroot and dropped privleges. This fixes the problem by executing the `fcinit.SetupNetwork` call _before_ running jailer and removing that hook from the `FcInit` functions later on. It also passes through the UID and GID options to the `tc-redirect-tap` plugin and includes the `IgnoreUnknown` directive so that chained CNI plugins work. Signed-off-by: Dan Norris <[email protected]>
protochron
force-pushed
the
jailer_cni_network
branch
2 times, most recently
from
8bd0685 to
88b0352
Compare
protochron
force-pushed
the
jailer_cni_network
branch
from
88b0352 to
f5dcecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there is a bug when trying to start a Firecracker VM with jailer using a CNI where the VM is never joined to the correct network namespace. This is because in its current form, the CNI execution occurs when
fcinit.SetupNetworkruns, which occurs after the jailer has already created a chroot and dropped privleges.This fixes the problem by executing the
fcinit.SetupNetworkcall before running jailer and removing that hook from theFcInitfunctions later on. It also passes through the UID and GID options to thetc-redirect-tapplugin and includes theIgnoreUnknowndirective so that chained CNI plugins work.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.