Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use re2js, its faster and much less complex build-wise #1439

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

firecow
Copy link
Owner

@firecow firecow commented Nov 26, 2024

No description provided.

@firecow firecow requested a review from ANGkeith November 26, 2024 17:26
@firecow firecow changed the title Use re2js, its faster and is much less complex build-wise Use re2js, its faster and much less complex build-wise Nov 26, 2024
@ANGkeith
Copy link
Collaborator

ANGkeith commented Nov 27, 2024

nice, it'll be much less complex build wise..

but seemed like it does not support some of the gitlab regex specs

ie.
image

@firecow
Copy link
Owner Author

firecow commented Nov 29, 2024

nice, it'll be much less complex build wise..

but seemed like it does not support some of the gitlab regex specs

ie. image

Yeah, I'll dig a bit, but will close the PR if it doesn't support the correct syntax.
Then I'll tryout https://github.com/google/re2-wasm

@firecow firecow marked this pull request as draft November 29, 2024 06:52
@ANGkeith
Copy link
Collaborator

ANGkeith commented Nov 29, 2024

I realize the syntax are actually supported, but looks like we'll need to do some refactoring ...
image


The re2-wasm does look better, since

only concern is that the project looks like it's in archived state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants