feat: Parse screenName in ProvidedUserInfo #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Apr 9, 2024
lahirumaramba
requested changes
Apr 9, 2024
sixstone-qq
force-pushed
the
sixstone-qq/add-screen-name-get-user
branch
2 times, most recently
from
5da2b98
to
8a82f96
Compare
sixstone-qq
force-pushed
the
sixstone-qq/add-screen-name-get-user
branch
from
8a82f96
to
502f91e
Compare
This is available when having multiple providers where it provides a screen name such as Twitter or GitHub. See https://cloud.google.com/identity-platform/docs/reference/rest/v1/ProviderUserInfo for details. It's available at endpoints like accounts.lookup or projects.queryAccounts Signed-off-by: Enrique J. Hernández <[email protected]>
sixstone-qq
force-pushed
the
sixstone-qq/add-screen-name-get-user
branch
from
502f91e
to
b77aea8
Compare
|
@pragatimodi it would be great if you can take a look on it to merge it upstream? Thanks a lot for your help here. |
|
@lahirumaramba would this need an API council approval? or do we have an approved proposal for this already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
It tries to fix #610 .
Testing
Adapt existing mocked data.
API Changes
Adding a new public field to UserInfo only populated under ProvidedUserInfo that is available in public API