Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase Auth/Import Users: added a phone number to the user provider #541

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from

Conversation

mymyparty
Copy link

@mymyparty mymyparty commented Mar 14, 2023

This MR adds a phoneNumber field to the user provider struct.
Related issue: #540
There is no relevant existing test.

@google-cla
Copy link

google-cla bot commented Mar 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lahirumaramba
Copy link
Member

lahirumaramba commented Mar 24, 2023

Hi @mymyparty Thank you for your contribution. Please change the base branch to dev before we can start the review process.

https://github.com/firebase/firebase-admin-go/blob/master/CONTRIBUTING.md#want-to-submit-a-pull-request

Make sure to create all your pull requests against the dev branch. All development work takes place on this branch, while the master branch is dedicated for released stable code. This enables us to review and merge routine code changes, without impacting downstream applications that are building against our master branch.

@mymyparty mymyparty changed the base branch from master to dev March 24, 2023 17:52
@mymyparty
Copy link
Author

@lahirumaramba done

@mymyparty
Copy link
Author

@lahirumaramba Hi! Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants