Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show all numbers as a Persian digit #64

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

MetaiR
Copy link

@MetaiR MetaiR commented Apr 1, 2018

I tried to make an attribute for this. but unfortunately, I didn't have enough time for reading your code exactly and do that. so (if you accept this pull request,) I hope you create something like that.

before you ask:
why don't we use a font for doing this?

because sometimes (like my case) we have an already existing project which has some predefined fonts and all parts and weights are based on it so we can't change it.

@MetaiR MetaiR changed the title Persian digits show all numbers as a Persian digit Apr 1, 2018
@fingerpich
Copy link
Owner

Hi
Thank you buddy
its great but i think it would make a lot of problem.
Please make a demo and npm version for your fork and make everything ok then I would add a link to your fork for using persian digits.

@MetaiR
Copy link
Author

MetaiR commented Apr 3, 2018

Actually, I wanted to do that but because it is a fork I preferred to make a new pull request first.
thanks for permission, I will do it.

right now you can install and use it with npm+git like this (if you want test it):
npm install git+https://github.com/MetaiR/jalali-angular-datepicker.git#built --save
I'll also create a demo and publish it to npm

@MetaiR MetaiR mentioned this pull request Apr 7, 2018
@MetaiR
Copy link
Author

MetaiR commented Apr 7, 2018

@fingerpich
I create your demo with the edited library
you can see it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants