-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use compact prompt when generating requests via Claude 3.5 #277
base: main
Are you sure you want to change the base?
Conversation
d488ad6
to
8dbd602
Compare
commit: |
9a55362
to
c268d09
Compare
noice - just looked over the prompt changes, will test locally tomorra |
haven't fully finished the vibe check, but one thing i did notice is that it's a little flaky with query params now? tested on a few routes in goose quotes that accepted query params and every once in a while it would add them, but most of the time not. old prompt always adds query params fwiw. other notes:
Will keep testing a bit more this eve |
separate question: you said you tested on our data we'd collected from our internal honcathons. do you have scripts available for those tests? how did you go about that? |
oh also! one more thing. it does tend to add the |
i had a bit in prompt to emphasize reusing the data from history, wasnt sure if that would be preferable so i left it out, will put it back. the fpx-trace-id is being added because we include it in history of requests, probably will disappear if we filter the headers there |
af8a30f
to
9b1323a
Compare
9b1323a
to
48089a4
Compare
i have modified the inference logic to remove trace header from history entries, so it shouldn't be resurfacing in responses anymore. i also added a bit to integrate previous requests data, so that should be resolved too |
this pr adds a slim version of system prompt for ai request generation and a suite of tests to evaluate its effects on the results (using goose-quotes from examples). as running these on each commit would be rather expensive and claude api is not fully deterministic at temp=0, they are not run by default, but instructions are provided inside the test.