Skip to content

Commit

Permalink
ruby30,32,33: Remove inappropriate -std=c99.
Browse files Browse the repository at this point in the history
The Portfile has been carrying the -std=c99 setting (for OS <10.7)
forward through many versions, but that has been inappropriate since
ruby30, when the compiler selection was switched by the thread-local
storage requirement.  Since the compiler now defaults to C11,
specifying C99 is a step backward.  This removes that inappropriate
setting.

Since this is not known not to impact the installed content, it
includes a revbump.

Also, since the latest legacy-support includes fgetattrlist(), builds
of ruby32-33 for <10.6 no longer include the private fallback, making
the installed content different on those platforms.  The revbump
covers that as well.

Also removes unnecessary "platforms darwin", making lint happy.

TESTED:
Minimally tested on unaffected 10.7+.
Built successfully with no variants on 10.4-10.5 ppc, 10.4-10.6 i386,
and 10.5-10.6 x86_64.
Built with all variants except jemalloc and yjit on 10.4-10.5, and all
variants except yjit on 10.6.
Universal included for ruby30 on 10.6.
Tests not run due to test framework issues.
  • Loading branch information
fhgwright committed Aug 9, 2024
1 parent 8b10d9f commit 1977a20
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
4 changes: 1 addition & 3 deletions lang/ruby30/Portfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@ PortGroup compiler_blacklist_versions 1.0

name ruby30
version 3.0.7
revision 0
revision 1

categories lang ruby
maintainers {kimuraw @kimuraw} \
{fwright.net:fw @fhgwright} \
openmaintainer
platforms darwin

description Powerful and clean object-oriented scripting language
long_description Ruby is the interpreted scripting language for quick \
Expand Down Expand Up @@ -213,7 +212,6 @@ platform darwin {
depends_build-append port:gmake
build.cmd ${prefix}/bin/gmake
configure.args-append --disable-dtrace
configure.cflags-append -std=c99
}

if {${os.major} == 8} {
Expand Down
4 changes: 1 addition & 3 deletions lang/ruby32/Portfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@ set ruby_patch 5
set ruby_ver_nodot [string map {. {}} ${ruby_ver}]
name ruby${ruby_ver_nodot}
version ${ruby_ver}.${ruby_patch}
revision 0
revision 1

categories lang ruby
maintainers {kimuraw @kimuraw} \
{fwright.net:fw @fhgwright} \
openmaintainer
platforms darwin

description Powerful and clean object-oriented scripting language
long_description Ruby is the interpreted scripting language for quick \
Expand Down Expand Up @@ -179,7 +178,6 @@ platform darwin {
depends_build-append port:gmake
build.cmd ${prefix}/bin/gmake
configure.args-append --disable-dtrace
configure.cflags-append -std=c99
}

if {${os.major} == 8} {
Expand Down
4 changes: 1 addition & 3 deletions lang/ruby33/Portfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@ set ruby_patch 4
set ruby_ver_nodot [string map {. {}} ${ruby_ver}]
name ruby${ruby_ver_nodot}
version ${ruby_ver}.${ruby_patch}
revision 2
revision 3

categories lang ruby
maintainers {kimuraw @kimuraw} \
{fwright.net:fw @fhgwright} \
openmaintainer
platforms darwin

description Powerful and clean object-oriented scripting language
long_description Ruby is the interpreted scripting language for quick \
Expand Down Expand Up @@ -186,7 +185,6 @@ platform darwin {
depends_build-append port:gmake
build.cmd ${prefix}/bin/gmake
configure.args-append --disable-dtrace
configure.cflags-append -std=c99
}

if {${os.major} == 8} {
Expand Down

0 comments on commit 1977a20

Please sign in to comment.