Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): relocate query #401

Merged
merged 21 commits into from
Jul 29, 2024
Merged

refactor(core): relocate query #401

merged 21 commits into from
Jul 29, 2024

Conversation

Archento
Copy link
Member

Proposed Changes

Since the restructuring of the Context object and the creation of the new communication.py module it made sense to unify the functionality of query with a send_message and remove redundant code.

Dependencies

To be merged after #399

Types of changes

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

@Archento Archento requested a review from jrriehl May 31, 2024 12:10
Base automatically changed from chore/update-context-arguments-typing to main June 14, 2024 14:04
@Archento Archento marked this pull request as ready for review June 14, 2024 14:31
@Archento Archento requested a review from lrahmani as a code owner July 18, 2024 12:13
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Archento Archento merged commit 7352046 into main Jul 29, 2024
9 checks passed
@Archento Archento deleted the refactor/relocate-query branch July 29, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants