feat: link TOC from presentation index #54
Conversation
- moved TOC related files into the presentation folder tree - linked TOC from each language intro.chapter page - link the presentation's index on the GH page on the README
|
Would it also make sense to just render them through the Javascript in that case? Currently, they are hand-compiled.
… On 21. Apr 2017, at 16:16, Ernesto Míguez ***@***.***> wrote:
• moved TOC related files into the presentation folder tree, under toc folder
• linked TOC from each language intro.chapter page
• link the presentation's index on the GH page on the README
You can view, comment on, or merge this pull request online at:
#54
Commit Summary
• feat: link TOC from presentation index
File Changes
• M README.md (4)
• D courses/default.html (81)
• D courses/default.md (70)
• D courses/english.html (81)
• D courses/english.md (70)
• D courses/spanish.html (81)
• D courses/spanish.md (70)
• M presentation/chapters/de-DE/intro.chapter (2)
• M presentation/chapters/en-US/intro.chapter (4)
• M presentation/chapters/es-ES/intro.chapter (30)
• A presentation/toc/default.html (80)
• A presentation/toc/default.md (69)
• A presentation/toc/english.html (80)
• A presentation/toc/english.md (69)
• A presentation/toc/spanish.html (80)
• A presentation/toc/spanish.md (69)
• M src/bin/build-indices.rs (4)
Patch Links:
• https://github.com/skade/rust-three-days-course/pull/54.patch
• https://github.com/skade/rust-three-days-course/pull/54.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Sure, I would do that in a later PR , but for the current issue I think the PR fulfils its needs @ |
There was a problem hiding this comment.
Looks good, thanks 😄
I just have one comment about the TOC acronym.
And, after these changes, were you able to use the navigation arrows?
I tried and I noticed that now the arrows are not working. It was buggy before, in my case only the english version worked, but now in all languages is failing.
| # Rust in three days | ||
|
|
||
| [TOC](toc/english.html) |
There was a problem hiding this comment.
Maybe the TOC acronym can be expanded.
There was a problem hiding this comment.
Ah, good idea, will expand that and also I18n the acronym
|
Tried with a local server and worked. It seems I can't navigate this on github pages, being a fork... |
Unnecessary since the link to presentation already renders it
|
@ericho had to push the branch to master on my fork, to get this rendered, but payed off: https://emig.github.io/rust-three-days-course/presentation/#/ you can check the end result. |
|
This may allow for the deprecation of https://github.com/skade/rust-three-days-course/blob/master/src/bin/build-indices.rs |
|
@emig I verified the result in your fork. LGTM. |
|
@Hoverbear added an issue for removing the |
intro.chapterpagecloses #53