Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp fix for serialport on macos 11 #145

Merged
merged 5 commits into from
Apr 20, 2021
Merged

temp fix for serialport on macos 11 #145

merged 5 commits into from
Apr 20, 2021

Conversation

spookyvision
Copy link
Contributor

No description provided.

Copy link

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! Could you please open an issue to revert this fix, and maybe mention it in the comments where you introduce your fork of serialport?

We might also want to move this fork to the Ferrous space.

@@ -198,7 +198,7 @@ pub fn serial_term() -> color_eyre::Result<()> {
}
};

let mut port = serialport::open(&dongle.port_name)?;
let mut port = serialport::new(&dongle.port_name, 9600).open()?;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9600 is pretty low, would you mind trying this with 115200, which is a pretty standard speed as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9600 was the default speed for serialport::open (I checked :D )
115200 works for dongle-flash and serial-term (actually now I get regular packets of received 45 bytes (CRC=Ok(0xc0ba), LQI=15); previously I only saw the double now listening on channel 20 from troubleshooting)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's switch it over, we can beta test in the training tomorrow, and hotpatch it back quickly if we need to :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already did!

@spookyvision
Copy link
Contributor Author

spookyvision commented Apr 20, 2021

Overall looks good to me! Could you please open an issue to revert this fix, and maybe mention it in the comments where you introduce your fork of serialport?

issue created - I don't understand the "mention in the comments..." part

We might also want to move this fork to the Ferrous space.

it's on git lab - do we have anything there?

xtask/Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: James Munns <[email protected]>
@jamesmunns
Copy link

it's on git lab - do we have anything there?

I'd say:

  • Do a clone
  • Make a new github repo
  • Push the clone to the new repo

@spookyvision spookyvision merged commit 70037a4 into main Apr 20, 2021
@spookyvision spookyvision deleted the macos-usb-hotfix branch April 20, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants