-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temp fix for serialport on macos 11 #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me! Could you please open an issue to revert this fix, and maybe mention it in the comments where you introduce your fork of serialport?
We might also want to move this fork to the Ferrous space.
xtask/src/tasks.rs
Outdated
@@ -198,7 +198,7 @@ pub fn serial_term() -> color_eyre::Result<()> { | |||
} | |||
}; | |||
|
|||
let mut port = serialport::open(&dongle.port_name)?; | |||
let mut port = serialport::new(&dongle.port_name, 9600).open()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9600 is pretty low, would you mind trying this with 115200
, which is a pretty standard speed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9600 was the default speed for serialport::open
(I checked :D )
115200 works for dongle-flash
and serial-term
(actually now I get regular packets of received 45 bytes (CRC=Ok(0xc0ba), LQI=15)
; previously I only saw the double now listening on channel 20
from troubleshooting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's switch it over, we can beta test in the training tomorrow, and hotpatch it back quickly if we need to :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already did!
issue created - I don't understand the "mention in the comments..." part
it's on git lab - do we have anything there? |
Co-authored-by: James Munns <[email protected]>
I'd say:
|
No description provided.