This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
shoehorn hickory's on-the-fly signing into the NameServer<Signed> API #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this implementation is super hacky. we should probably add a
new type state, e.g. `OnTheFlySigning`, to support
runtime ("on-the-fly") signing of records, which only BIND and hickory
implement
japaric
force-pushed
the
ja-hickory-name-server-with-actual-signing
branch
from
463d93e
to
4012b34
Compare
justahero
reviewed
May 13, 2024
| // -2 = use SHA256 for the DS hash | ||
| let key2ds = format!("cd {ZONES_DIR} && ldns-key2ds -n -2 {ZONE_FILENAME}.signed"); | ||
| let ds: DS = container.stdout(&["sh", "-c", &key2ds])?.parse()?; | ||
| let state = if is_hickory { |
There was a problem hiding this comment.
Imho this function is quite large, maybe to code in the conditional can be extracted, something like:
let state = if implementation.is_hickory {
// automatic on-the-fly
hickory_sign_zonefile(&container, &zone_file, zone.clone())?
} else {
// manual ahead-of-time signing
manual_sign_zonefile(&container, &zone_file, zone.clone())?
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this implementation is super hacky. we should probably add a new type state, e.g.
OnTheFlySigning, to supportruntime ("on-the-fly") signing of records, which only BIND and hickory implement